Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Nextcloud Version 20.0 #331

Closed
Slinky-Wrangle-Punch opened this issue Oct 6, 2020 · 16 comments
Closed

Compatibility with Nextcloud Version 20.0 #331

Slinky-Wrangle-Punch opened this issue Oct 6, 2020 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@Slinky-Wrangle-Punch
Copy link

After Upgrading to Nextcloud 20 the App is marked as untested App. It says "Server version 19 or lower is required.". An Update of the App for Nextcloud 20.0 is necessary.

@Slinky-Wrangle-Punch Slinky-Wrangle-Punch added the enhancement New feature or request label Oct 6, 2020
@christianlupus
Copy link
Collaborator

Have you tried if the app can be activated nevertheless? Are there any issues?

@christianlupus
Copy link
Collaborator

PS: I just saw this line. So i t seams with the very next release, the issue should be gone.

@Slinky-Wrangle-Punch
Copy link
Author

It seems like it is working without any problems if I activate it nevertheless

@christianlupus christianlupus changed the title Compatibility with Nextcloud Version 20.0 Compatibility with Nextcloud Version 21.0 Oct 9, 2020
@christianlupus
Copy link
Collaborator

I changed to 21 as this one is currently not compatible according to the app info. We need to test here.

@steeljm1
Copy link

I can confirm that upgrading from 19.0.4 -> 20.0.0 the app is functional after enabling it i.e. view, create, and edit recipes. No warnings/errors in logs.

@christianlupus christianlupus changed the title Compatibility with Nextcloud Version 21.0 Compatibility with Nextcloud Version 20.0 Oct 11, 2020
@christianlupus
Copy link
Collaborator

OK, as there was some unclarity if this issue is related to 20 or 21, I reverted back to 20 and close this on as the app seems compatible with 20. Thanks for testing @steeljm1.

@obbardc
Copy link

obbardc commented Nov 8, 2020

On the app page, it doesn't state compatibility with v20: https://apps.nextcloud.com/apps/cookbook

@christianlupus
Copy link
Collaborator

Yes, as there was no release published since the v20 compatibility was set.

@matclou
Copy link

matclou commented Nov 16, 2020

Hello, I am running the app (0.7.6) on Nextcloud 20.0.1 and I am missing the search option in the right menu:

grafik

Is this issue related to V20?

@christianlupus
Copy link
Collaborator

@matclou Unless this problem is purely related to V20 (aka working differently on NC V19), this is a separate issue.
Where do you expect the search to appear? On the release there is no search yet implemented. But maybe you are referring to something differently so I wanted to make sure. Especially because you are referring the right menu but showing a screenshot of the top left edge.

@matclou
Copy link

matclou commented Nov 17, 2020

Dear Christian, oh I did not know this. And indeed I meant the left menu and not the right menu!

As I am a beginner in using the cookbook app I took the screenshot visible at https://apps.nextcloud.com/apps/cookbook as granted: There is a search function implemented in the left menu.

So there is currently no search function integrated?

EDIT: And is this on the agenda of the project? Otherwise a very nice project but if you handle very large numbers of recipes a search function which also makes use of the tags is of course useful! ;-)

@christianlupus
Copy link
Collaborator

@matclou This was replaced by another feature in #318. This is not yet published so it might take a bit of time. The search as depicted in the app store was removed a few releases ago as it was faulty.

@matclou
Copy link

matclou commented Nov 17, 2020

That is good to know - thanks for informing and your work! ;-)

@Obi-Wahn
Copy link

Thanks for the app! I'm looking forward to a release with v20 compatibility!

@radoeka
Copy link

radoeka commented Nov 28, 2020

Thanks for the app! I'm looking forward to a release with v20 compatibility!

Is it possible to just release for NC-20. NC-20 is now listed as general available (via the stable update channel). It's likely that more people start to move to NC-20. It would be nice to have Cookbook listed as compatible with NC-20.

@obbardc
Copy link

obbardc commented Nov 28, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants