Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make info blocks configurable, whether displayed or not displayed #906

Closed
cloud2018 opened this issue Mar 5, 2022 · 6 comments · Fixed by #1404
Closed

Make info blocks configurable, whether displayed or not displayed #906

cloud2018 opened this issue Mar 5, 2022 · 6 comments · Fixed by #1404
Assignees
@MarcelRobitaille
Labels
API changes involving using the app api Backend Issue or PR related to the backend code enhancement New feature or request Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code php Pull requests that update Php code

Comments

@cloud2018
Copy link

cloud2018 commented Mar 5, 2022 •
edited by christianlupus
Loading

It would be nice to be able to configure which info blocks should be displayed on the recipe and which should not.
E. g. the info blocks Preparation time (hours:minutes); Cooking time (hours:minutes); Total time (hours:minutes); Nutrition Information; Tools are not interesting for me and distract from important (for me) part.

The configuration should be global and not depending on the recipe

Depends on #1067
@cloud2018 cloud2018 added the enhancement New feature or request label Mar 5, 2022
@christianlupus christianlupus added php Pull requests that update Php code javascript Pull requests that update Javascript code Backend Issue or PR related to the backend code Frontend Issue or PR related to the frontend code labels May 13, 2022
@christianlupus
Copy link
Collaborator

christianlupus commented Jul 3, 2022 •
edited
Loading

The configuration of the app needs more settings.

Depends on #1067

@christianlupus christianlupus added the API changes involving using the app api label Jul 8, 2022
@christianlupus christianlupus mentioned this issue Jul 8, 2022
Open
@github-actions
Copy link

This PR/issue depends on:

@MarcelRobitaille
Copy link
Collaborator

I have started to work on this. I have only created the UI for this feature. The settings are not being save or used anywhere.

image

I will work on saving the settings next.

@christianlupus
Copy link
Collaborator

If you need help with the backend part, just ping me.

@christianlupus
Copy link
Collaborator

PS: Without a link to a branch, we cannot help you much...

@MarcelRobitaille MarcelRobitaille mentioned this issue Dec 29, 2022
Merged
3 tasks
@MarcelRobitaille
Copy link
Collaborator

@christianlupus Sorry, I've been very busy. Here is my branch: https://github.com/MarcelRobitaille/cookbook/tree/906-hide-info-blocks. I opened a draft pull request to track the progress: #1404.

@MarcelRobitaille MarcelRobitaille self-assigned this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcelRobitaille MarcelRobitaille

Labels
API changes involving using the app api Backend Issue or PR related to the backend code enhancement New feature or request Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make info block visibility configurable MarcelRobitaille/cookbook
3 participants
@christianlupus @MarcelRobitaille @cloud2018