Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an app configuration #1067

Closed
christianlupus opened this issue Jul 3, 2022 · 3 comments · Fixed by #1258
Closed

Create an app configuration #1067

christianlupus opened this issue Jul 3, 2022 · 3 comments · Fixed by #1258
Assignees
Labels
enhancement New feature or request Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code

Comments

@christianlupus
Copy link
Collaborator

Currently, our app is configured in a small overlay in the lower-left corner of the screen.

As more and more requests related to configurable enhancements are on the bug tracker, it might be a considerable approach to put the settings into a full-frame page. This can be done in different ways:

  • the per-user configuration and register with the NC core
  • a custom setting page (overlay or similar) that can be made visible

In this issue, the usage of mobile devices should be made as an additional request: Any changes to the settings should be easily achievable also on a mobile screen with touch control.

@christianlupus christianlupus added the enhancement New feature or request label Jul 3, 2022
@christianlupus christianlupus changed the title Create a app configuration Create an app configuration Jul 3, 2022
@christianlupus
Copy link
Collaborator Author

I asked at the design team how we should design the settings best. Here I (Cross-) post for reference and to keep track.

grafik
grafik

The Link is extracted here

@christianlupus christianlupus added Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code labels Jul 15, 2022
@MarcelRobitaille
Copy link
Collaborator

To be clear, the current objective is to replace the settings overleay in the bottom left corner of the app with a modal similar to the Nextcloud Talk app? Can the same button that currently toggles the overleay be use to bring up the modal?

Here is a screenshot of that app's settings modal. Also visible is the "Talk settings" button that brings up this modal.

image

@christianlupus
Copy link
Collaborator Author

Exactly, that was the idea behind it, @MarcelRobitaille.

@MarcelRobitaille MarcelRobitaille self-assigned this Oct 17, 2022
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Oct 18, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Oct 18, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
christianlupus pushed a commit to MarcelRobitaille/cookbook that referenced this issue Oct 18, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Oct 19, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Nov 1, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Nov 1, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Nov 1, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille added a commit to MarcelRobitaille/cookbook that referenced this issue Nov 30, 2022
Fixes nextcloud#1067

Move the AppNavigationSettings from the sidebar to a AppSettingsDialog
modal that covers the screen.

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants