-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same Markdown parser as other NC apps #991
Comments
Nextcloud Notes uses markdown-it as does the Markdown Editor and the Tasks app. So I would suggest switching to the same. Edit: There are differences in the loaded plugins for markdown-it though: The Notes App does not load any plugins. The Tasks app loads
while the Markdown editor has dependencies on
The Text App uses
Also for the core module multiple options can be set, so we still need to decide on the exact setup we want to use. |
The markdown-it is a parser of Markdown as far as I know. So it takes a markdown text and renders it in HTML, right? I was more about the editor part. We could use a plain text editor, can't we? We need to tweak it anyways to do the #903 topic. |
Hello there, I could try to resolve this issue for you |
Hello @harris2310. Thank you for your willingness to support the app. It would be appreciated if you could provide a solution for the issue. Just comment that you are working on it and we will assign it to you (to prevent doubled work). I will be away in the next few days but you can start on it as you see fit. If you have questions or doubts, feel free to ask. |
Ima start working on it right now! |
Hello @harris2310 did you succeed in getting this fix started? Is there anything missing that we can support you? |
Sorry christian, I won't be able to work on it cause I'll probably catch a job |
OK, I will unassign you then. |
No worries, we are not too active ATM. |
See #991 Signed-off-by: Christian Wolf <github@christianwolf.email>
See #991 Signed-off-by: Christian Wolf <github@christianwolf.email>
I wrote a fix for the main problem. This is not zet the compatible version as suggested e.g. in this comment. The fix was just introduced to fix a security issue in NPM. |
@MarcelRobitaille is this issue closed when the current PRs are merged? I just wanted to ask if there is still something open to be done. |
I don't think so. I did not change the markdown editor, I only changed some things around it. |
The editor I changed. This was the issue with the paste function we were discussing in the other issue/PR. I checked it once more. I will update the title as the topic is solved partially. |
I don't think this needs to remain open for any of my PRs then, to answer your question more directly. |
The currently used markdown core
v-markdown-editor
seems to no longer be maintained. We should switch to another markdown solution.At best we would use a compatible code with other NC apps to have the same flavor.
The text was updated successfully, but these errors were encountered: