Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use singular/plural form for translations #1026

Merged
merged 4 commits into from
May 30, 2022

Conversation

christianlupus
Copy link
Collaborator

Closes #1022.

@Valdnet is this correctly done as you suggested? Please approve if yes.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus requested a review from Valdnet May 26, 2022 09:15
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus enabled auto-merge May 26, 2022 09:16
@christianlupus
Copy link
Collaborator Author

I just saw that i have to fix the tests. Will do so soon.

@christianlupus christianlupus disabled auto-merge May 30, 2022 06:06
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1026 (0450ec9) into master (08fde85) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0450ec9 differs from pull request most recent head cfd463b. Consider uploading reports for the commit cfd463b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1026   +/-   ##
=======================================
  Coverage   40.65%   40.65%           
=======================================
  Files          42       42           
  Lines        1852     1852           
=======================================
  Hits          753      753           
  Misses       1099     1099           
Flag Coverage Δ
integration 4.58% <0.00%> (ø)
unittests 36.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/HtmlToDomParser.php 95.16% <100.00%> (ø)

@github-actions
Copy link

Unit Test Results

     24 files       24 suites   9m 18s ⏱️
   192 tests    192 ✔️ 0 💤 0
2 304 runs  2 304 ✔️ 0 💤 0

Results for commit cfd463b.

@christianlupus christianlupus merged commit 75dd43f into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/1022-singular-xml-error-message branch May 30, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

l10n: Singular and plural
2 participants