Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the url to the parsers of the recipes to allow for domain-specific parsers #1060

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

christianlupus
Copy link
Collaborator

Closes #217

This is the last part to finish the structure in order to make domain-antagonistic parsers possible.

…ic parsers

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1060 (933c3ce) into master (c384b23) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   44.58%   44.58%           
=======================================
  Files          50       50           
  Lines        1965     1965           
=======================================
  Hits          876      876           
  Misses       1089     1089           
Flag Coverage Δ
integration 2.29% <0.00%> (ø)
migration 4.32% <0.00%> (ø)
unittests 37.96% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/HTMLParser/AbstractHtmlParser.php 100.00% <ø> (ø)
lib/Service/RecipeService.php 0.00% <0.00%> (ø)
lib/Helper/HTMLParser/HttpJsonLdParser.php 100.00% <100.00%> (ø)
lib/Helper/HTMLParser/HttpMicrodataParser.php 100.00% <100.00%> (ø)
lib/Service/RecipeExtractionService.php 100.00% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Unit Test Results

     36 files       36 suites   8m 45s ⏱️
   227 tests    227 ✔️ 0 💤 0
2 724 runs  2 724 ✔️ 0 💤 0

Results for commit 933c3ce.

@christianlupus christianlupus enabled auto-merge July 1, 2022 10:23
@christianlupus christianlupus disabled auto-merge July 1, 2022 10:23
@christianlupus christianlupus merged commit d837c96 into master Jul 1, 2022
@christianlupus christianlupus deleted the maintenance/217-url-in-parser branch July 1, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalise the HTML parsing procedure to allow for more parsing options
1 participant