Skip to content

Fix XPath in microdata parser #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

christianlupus
Copy link
Collaborator

Closes #1209

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1220 (15dfa4a) into master (47a503e) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files          85       85           
  Lines        2376     2376           
=======================================
  Hits         1773     1773           
  Misses        603      603           
Flag Coverage Δ
integration 20.45% <0.00%> (ø)
migration 3.91% <0.00%> (ø)
unittests 54.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/HTMLParser/HttpMicrodataParser.php 100.00% <100.00%> (ø)

@github-actions
Copy link

Unit Test Results

     27 files       27 suites   6m 40s ⏱️
   473 tests    473 ✔️ 0 💤 0
4 257 runs  4 256 ✔️ 1 💤 0

Results for commit 15dfa4a.

@christianlupus christianlupus merged commit 8f9df65 into master Sep 22, 2022
@christianlupus christianlupus deleted the fix/1209-microdata-parser branch September 22, 2022 20:17
@christianlupus christianlupus added this to the Release 0.9.16 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import from frischgekocht.billa.at fails with non-descriptive error.
1 participant