Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1210 recipe filtering resulting in non-contiguous arrays #1222

Merged

Conversation

christianlupus
Copy link
Collaborator

Closes #1210

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus added this to the Release 0.9.16 milestone Sep 23, 2022
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@github-actions
Copy link

Unit Test Results

     27 files       27 suites   6m 42s ⏱️
   476 tests    476 ✔️ 0 💤 0
4 284 runs  4 283 ✔️ 1 💤 0

Results for commit 2425c93.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1222 (2425c93) into master (8f9df65) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
+ Coverage   74.62%   74.66%   +0.04%     
==========================================
  Files          85       85              
  Lines        2376     2380       +4     
==========================================
+ Hits         1773     1777       +4     
  Misses        603      603              
Flag Coverage Δ
integration 20.58% <100.00%> (+0.13%) ⬆️
migration 3.90% <0.00%> (-0.01%) ⬇️
unittests 54.28% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/Filter/JSON/FixIngredientsFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/FixInstructionsFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/FixToolsFilter.php 100.00% <100.00%> (ø)

@christianlupus christianlupus merged commit 3fecb77 into master Sep 23, 2022
@christianlupus christianlupus deleted the fix/1210-recipe-filtering-non-contigouus-arrays branch September 23, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions/ingredients not shown in editing view
1 participant