Fix of the build environment and the import Vue component #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1442 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 86 86
Lines 2303 2303
=======================================
Hits 1816 1816
Misses 487 487
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
|
/approve |
nextcloud-cookbook-bot
approved these changes
Jan 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import did no longer work. This was caused by handling of native events in the Vue app. The underlying library was updated and the event indices were wrong. Thus, it should be completely handled by Vue events.
Further, the build environment needed an update as it was missing a dependency.