Use new logging framework consistently #1459
Conversation
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
|
Some |
src/components/AppMain.vue
Outdated
| /* This is left here as an example in case the routes need to be debugged again | ||
| '$route' (to, from) { | ||
| console.log(this.$window.isSameBaseRoute(from.fullPath, to.fullPath)) | ||
| this.$log.debug(this.$window.isSameBaseRoute(from.fullPath, to.fullPath)) | ||
| }, | ||
| */ |
There was a problem hiding this comment.
These lines are commented out. After it is redirected to a debug-level logger, we could remove the comment and just let the logger ignore the logged data in the normal (non-debug) case. Am I right?
There was a problem hiding this comment.
Sure. Sounds like a plan.
Yes, I would say so, you can switch to the new logger with debugging level. This seems a good idea. A general question: What do you consider needed to finish this PR? |
|
I was just waiting for your feedback on how to handle |
Now, we don't need to comment them out, we can just change the log level Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Instead, just do everything through the logging API Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
|
Ahh, ok. Sorry for the delay. |
|
No worries. I've been super busy too. |
Signed-off-by: Christian Wolf <github@christianwolf.email>
Replace all instances of
console.logand alternatives withthis.$log.infoorVue.$log.info.In #1404, I noticed that although a logging framework was added in #1283,
console.logandconsole.errorwere still used frequently throughout the app. This PR aims to replace all of these with the logging framework.