Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for issue with axios #1764

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Workaround for issue with axios #1764

merged 4 commits into from
Jul 21, 2023

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

This is a quick fix for #1753.

Concerns/issues

This just cures the symptoms to avoid user disturbance. It should be fixed also on lower levels (#1752).

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus linked an issue Jul 21, 2023 that may be closed by this pull request
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

Test Results

     27 files  1 233 suites   7m 58s ⏱️
   498 tests    498 ✔️ 0 💤 0
4 482 runs  4 481 ✔️ 1 💤 0

Results for commit fa44fdd.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus enabled auto-merge July 21, 2023 15:19
@christianlupus christianlupus merged commit f1b01cd into master Jul 21, 2023
@christianlupus christianlupus deleted the fix/axios branch July 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error of configuration pops up on reloading
2 participants