Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide copy button if array is empty #1844

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

Closes #1823

This is just a minor UI issue fixed.

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus added this to the Release 0.10.3 milestone Oct 12, 2023
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1844 (05da172) into master (4920340) will decrease coverage by 5.87%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1844      +/-   ##
==========================================
- Coverage   79.67%   73.80%   -5.87%     
==========================================
  Files          89       89              
  Lines        2573     2573              
==========================================
- Hits         2050     1899     -151     
- Misses        523      674     +151     
Flag Coverage Δ
integration 21.88% <ø> (ø)
migration ?
unittests 56.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@christianlupus christianlupus merged commit 925e141 into master Oct 12, 2023
@christianlupus christianlupus deleted the fix/1823-no-copy-empty-ingredients branch October 12, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot copy empty ingredients
2 participants