Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/prep time cook time not correctly imported #1871

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix/prep time cook time not correctly imported #1871

merged 3 commits into from
Oct 30, 2023

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Oct 30, 2023

Topic and Scope

Support ISO 8601 formatted strings such as in #1749. Closes #1749.

Concerns/issues

We might need to revisit this if someone decides to have timers with years, months, or days set. But this should be easy to extend.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

seyfeb added 3 commits October 30, 2023 21:46
@seyfeb
fix: Support wider range of ISO 8601 period strings
540e378 
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
@seyfeb
test: Add tests for ISO 8601 duration helper
3347750 
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
@seyfeb
docs: Update CHANNGELOG
0e999ef 
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
@seyfeb seyfeb added php Pull requests that update Php code Backend Issue or PR related to the backend code labels Oct 30, 2023
@seyfeb
Copy link
Collaborator Author

seyfeb commented Oct 30, 2023

/approve

nextcloud-cookbook-bot
nextcloud-cookbook-bot approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

Test Results

     27 files  1 242 suites   7m 14s ⏱️
   506 tests    506 ✔️ 0 💤 0 ❌
4 554 runs  4 553 ✔️ 1 💤 0 ❌

Results for commit 0e999ef.

@seyfeb seyfeb merged commit 66dd1fe into nextcloud:master Oct 30, 2023
@seyfeb seyfeb deleted the fix/prepTime-cookTime-not-correctly-imported branch October 30, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextcloud-cookbook-bot nextcloud-cookbook-bot nextcloud-cookbook-bot approved these changes

Assignees
No one assigned
Labels
Backend Issue or PR related to the backend code php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'prepTime', 'cookTime' and 'totalTime' attributes are not read from recipe in JSON-LD
2 participants
@seyfeb @nextcloud-cookbook-bot