Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to check PHP for syntac compatibility #1931

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

This should solve #1929

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1931 (230c84b) into master (ddda5cc) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1931   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          92       92           
  Lines        2650     2650           
=======================================
  Hits         2122     2122           
  Misses        528      528           
Flag Coverage Δ
integration 21.43% <0.00%> (ø)
migration 5.69% <0.00%> (ø)
unittests 57.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/Helper/Filter/JSON/AbstractJSONFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/Output/RecipeStubFilter.php 100.00% <ø> (ø)
lib/Helper/TimestampHelper.php 100.00% <100.00%> (ø)

Copy link

github-actions bot commented Dec 5, 2023

Test Results

     27 files  1 287 suites   5m 25s ⏱️
   552 tests    552 ✔️ 0 💤 0
4 968 runs  4 967 ✔️ 1 💤 0

Results for commit 230c84b.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit c4a8fdd into master Dec 5, 2023
40 checks passed
@christianlupus christianlupus deleted the fix/1929-php-linting-with-correct-version branch December 5, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants