Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove constant se in RecipeView #1942

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix: remove constant se in RecipeView #1942

merged 2 commits into from
Dec 6, 2023

Conversation

j0hannesr0th
Copy link
Contributor

@j0hannesr0th j0hannesr0th commented Dec 6, 2023

Topic and Scope

@christianlupus there's a hardcoded "se" visible on all recipe pages

Concerns/issues

none

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: j0hannesr0th <36242595+j0hannesr0th@users.noreply.github.com>
Signed-off-by: j0hannesr0th <36242595+j0hannesr0th@users.noreply.github.com>
Copy link

github-actions bot commented Dec 6, 2023

Test Results

     27 files  1 287 suites   5m 24s ⏱️
   552 tests    552 ✔️ 0 💤 0
4 968 runs  4 967 ✔️ 1 💤 0

Results for commit b192481.

@christianlupus christianlupus merged commit 9e678bc into nextcloud:master Dec 6, 2023
23 checks passed
@christianlupus
Copy link
Collaborator

Uups, sorry for that.

@christianlupus
Copy link
Collaborator

/cb-backport main-0.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants