Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1970 cooking prep and total time are not filled during edits #1973

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix/1970 cooking prep and total time are not filled during edits #1973

merged 3 commits into from
Dec 13, 2023

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 12, 2023

Topic and Scope

Show the initial values of cooking, prep, and total time in the recipe editor.

Closes #1970

Concerns/issues

Based on #1950

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@seyfeb seyfeb mentioned this pull request Dec 12, 2023
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Test Results

552 tests   552 ✔️  19s ⏱️
143 suites      0 💤
    3 files        0 ❌

Results for commit 9318606.

@seyfeb @christianlupus
fix(Recipe editing): Show initial value in time-edit fields
38c677b 
Signed-off-by: Sebastian Fey <sebastian@arfinity.io>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@seyfeb @christianlupus
chore: Update CHANGELOG
05d189a 
Signed-off-by: Sebastian Fey <sebastian@arfinity.io>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@seyfeb @christianlupus
chore: Fix code style
1133a4b 
Signed-off-by: Sebastian Fey <sebastian@arfinity.io>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the fix/1970-cooking-prep-and-total-time-are-not-filled-during-edits branch from 9318606 to 1133a4b Compare December 13, 2023 07:56
@christianlupus christianlupus merged commit afc74d2 into master Dec 13, 2023
36 of 37 checks passed
@christianlupus christianlupus deleted the fix/1970-cooking-prep-and-total-time-are-not-filled-during-edits branch December 13, 2023 07:59
@christianlupus christianlupus mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianlupus christianlupus christianlupus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cooking, prep, and total time are not filled during edits
2 participants
@seyfeb @christianlupus