Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent searching in collapsed nutritient option field #1977

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Prevent searching in collapsed nutritient option field #1977

merged 3 commits into from
Dec 13, 2023

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

Closes #1969

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus
Prevent searching in collapsed nutritient option field
5579154 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Update Changelog
837c310 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus added this to the Release 0.11.0 milestone Dec 13, 2023
seyfeb
seyfeb approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@seyfeb seyfeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seyfeb
Merge branch 'master' into fix/1969-weired-cursor
f8cfca3 
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
@seyfeb seyfeb enabled auto-merge December 13, 2023 10:44
@seyfeb seyfeb merged commit b4e6fcd into master Dec 13, 2023
37 checks passed
@seyfeb seyfeb deleted the fix/1969-weired-cursor branch December 13, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seyfeb seyfeb seyfeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.11.0
Development

Successfully merging this pull request may close these issues.

Weird cursor in Select component after selecting option
2 participants
@christianlupus @seyfeb