-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the database requests for performance #297
Rework the database requests for performance #297
Conversation
cbe0e53
to
ea13c71
Compare
64f85c6
to
9b3866d
Compare
Before processing further with any optimizations, I wanted to ask for your opinion in these changes. I will not review them myself, as I think - of course 😀 - that my changes are the holy grail. To get a more critical feedback, I am asking you to look into this PR so far. |
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
…some no more needed functions Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
…ion source Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
992bd5a
to
e2983e5
Compare
I merge the changes here to get them into the main development branch. As only the DB is affected, we can always return to the old behavior without data loss. |
As discussed in #218 the database is used currently in a very bad way. This PR tries to optimize a bit of these accesses.
I want to be honest: This is more of a hack an less a real implementation in good manner. I found quite some issues in the code, that I will open soon document. There are yet some edges and
TODO
s in the code I have to iron out.If someone wants to have a look anyways and give some feedback or help with the issue, you are welcome. If you wanted to test it out, it should work. However, I suggest to have a backup of you JSON files 😃. I tried some cases here but for sure not all possible (edge) cases.
Open points regarding this PR