-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tag/keyword cloud to recipe view #373
Added tag/keyword cloud to recipe view #373
Conversation
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
I just looked at your code. I found that the code uses the endpoint Was this done by intention or just by chance? If not done by intention, you might need to register a corresponding search functionality in the search component. The backend needs to be adopted as well (registering a route, adding a controller method and implementing the search itself). |
Good spot, I figured the |
I just opened a PR against your fork @seyfeb with the backend work done (at least until the point I assume it is working, testing needs to be done). |
I already did this in parallel, although I went a slightly different route by not using the /tag/ endpoint and instead introduced a new /tags/ endpoint which takes a comma-separated list of tags which must all exist in a recipe to be returned ("AND" operation). This allows for single tag searches but is more flexible. Edit: We could provide both, though. |
OK, I'll let you do your work until you are done. BTW: These lines might have an issue with the colon in the parameter's name. |
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
336646b
to
dfc4839
Compare
I’m glad about any help! ;) |
I already closed the PR. I think the API should be kept as clean as possible, aka drop my suggestion, please. |
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
I requested @sam-19 as requestor as I am not very well suited for vue.js currently. I will look at the code soon as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PHP part seems good. I have two comments regarding Vue.JS but I am no expert in thsi field.
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
No issues that I can see, good job! I have avoided using $emit to parent component, because I had some lingering hopes about porting my Vue apps using Vue Native until recently. But since that will probably never happen, using emits is "better" Vue programming and I'll start adopting them more myself. |
Added list of keywords below the title in the recipe view. Klicking keyword routes to recipe list with corresponding tag.
Closes #247