Parse multiline ingredients and tools into separate fields #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyfeb
force-pushed
the
feature/parseMultilineIngredientsIntoSeparateFields
branch
from
f3fa615
to
7a080a6
Compare
|
Now, this is done for textareas, too. There are only frontend parts touched by this PR. @sam-19, as the vue.js magician here, could you have a look at this? |
CHANGELOG.md
Outdated
| @@ -48,6 +50,8 @@ | |||
| [#358](https://github.com/nextcloud/cookbook/pull/358) @christianlupus | |||
| - Avoid recipe are no longer reachable when user changes locales | |||
| [#371](https://github.com/nextcloud/cookbook/pull/371) @christianlupus | |||
| - Creating new recipe not possible due to null reference | |||
| [#378](https://github.com/nextcloud/cookbook/pull/378/) @seyfeb | |||
There was a problem hiding this comment.
I think this is a leftover from another PR...., right?
There was a problem hiding this comment.
Yeah, I merged #378 in there to be able to create new recipes at all. I can remove those lines.
There was a problem hiding this comment.
So, #378 should be merged before. All right.
There was a problem hiding this comment.
As I am no Vus.JS magician, I just looked over the general structure. I will request review by @sam-19.
sam-19
reviewed
Nov 10, 2020
|
Apart from the small comment above, it looks good to me! |
seyfeb
commented
Nov 10, 2020
sam-19
reviewed
Nov 10, 2020
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
…ntent with newlines is pasted Works for inputs, not for textarea (yet) Signed-off-by: Sebastian Fey <info@sebastianfey.de>
…s and ingredients Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
christianlupus
force-pushed
the
feature/parseMultilineIngredientsIntoSeparateFields
branch
from
29b5db9
to
fef3e6d
Compare
seyfeb
deleted the
feature/parseMultilineIngredientsIntoSeparateFields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recipe editor, pasting content with newlines in a tools or ingredients field automatically creates new fields.
For textareas (recipe steps) this is not done.
Closes #325.