Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate changes of the image to the recipe #505

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Jan 12, 2021

Closes #492

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #505 (bfc3db2) into master (bbaddcb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #505   +/-   ##
========================================
  Coverage      0.90%   0.90%           
  Complexity      416     416           
========================================
  Files            13      13           
  Lines          1319    1319           
========================================
  Hits             12      12           
  Misses         1307    1307           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 0.90% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator Author

@seyfeb would you please have a look here as well? Thanks

@seyfeb
Copy link
Collaborator

seyfeb commented Jan 12, 2021

looks good from the vue side, but for me it didn’t seem to download and store the image at the url

@seyfeb
Copy link
Collaborator

seyfeb commented Jan 12, 2021

Okay, I figured out, that my firewall was blocking the connection. Now it’s downloading the image 👍

@christianlupus christianlupus merged commit d443fe4 into master Jan 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/492-add-images-manually branch January 13, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pictures are not downloaded
2 participants