Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/vue from 1.5.0 to 3.5.4 #561

Merged
merged 6 commits into from
Feb 6, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 28, 2021

Bumps @nextcloud/vue from 1.5.0 to 3.5.4.

Release notes

Sourced from @nextcloud/vue's releases.

v3.5.4

v3.5.4 (2021-01-27)

Fixed

Added

Changed

v3.5.3

v3.5.3 (2021-01-25)

Fixed

  • Replace linkify-urls with linkifyjs to fix Safari incompatibility issues - #1678 (Vincent Petry)

v3.5.2

v3.5.2 (2021-01-22)

Fixed

v3.5.1

v3.5.0

v3.5.0 (2021-01-20)

Changed

v3.4.0

v3.4.0 (2021-01-18)

Added

... (truncated)

Changelog

Sourced from @nextcloud/vue's changelog.

v3.5.4 (2021-01-27)

Fixed

Added

Changed

v3.5.3 (2021-01-25)

Fixed

  • Replace linkify-urls with linkifyjs to fix Safari incompatibility issues - #1678 (Vincent Petry)

v3.5.2 (2021-01-22)

Fixed

v3.5.1 (2021-01-20)

Fixed

v3.5.0 (2021-01-20)

Changed

v3.4.0 (2021-01-18)

Added

... (truncated)

Commits
  • 97d2302 3.5.4
  • fb1c7b4 Update changelog for 3.5.4
  • ab6b0f9 Merge pull request #1620 from nextcloud/dependabot/npm_and_yarn/cypress-visua...
  • 7753cc1 Bump cypress-visual-regression from 1.5.5 to 1.5.6
  • a272011 Merge pull request #1682 from nextcloud/translations_l10n-messages-pot--maste...
  • a94e7fd Merge pull request #1672 from nextcloud/dependabot/npm_and_yarn/webpack-cli-4...
  • 7fdb4ad Merge pull request #1673 from nextcloud/dependabot/npm_and_yarn/stylelint-13.9.0
  • be1e479 Merge pull request #1676 from nextcloud/dependabot/npm_and_yarn/vue-eslint-pa...
  • 56e1f8b Merge pull request #1686 from nextcloud/dependabot/npm_and_yarn/vue-styleguid...
  • ee2bf39 Merge pull request #1685 from nextcloud/bugfix/1681/revert-tooltip-hack-fix-p...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 28, 2021
@dependabot dependabot bot requested a review from sam-19 January 28, 2021 02:33
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #561 (8fa6bd0) into master (f8c10be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #561   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      440     440           
========================================
  Files            13      13           
  Lines          1381    1381           
========================================
  Hits             14      14           
  Misses         1367    1367           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/vue-3.5.4 branch 2 times, most recently from 9d3483b to f716300 Compare February 4, 2021 18:57
dependabot bot and others added 6 commits February 5, 2021 18:10
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
…to current nextcloud-vue library

Signed-off-by: Sebastian Fey <info@sebastianfey.de>
…er of recipes next to categories in category-edit mode

Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
@seyfeb seyfeb force-pushed the dependabot/npm_and_yarn/nextcloud/vue-3.5.4 branch from f716300 to 8fa6bd0 Compare February 5, 2021 23:12
@seyfeb
Copy link
Collaborator

seyfeb commented Feb 5, 2021

I made several changes to accommodate for the new version which had some breaking changes.

While being at it, I split off the settings in the navigation pane to a separate component since it had become rather large.

For some reason editing the category name now doesn’t show the current name anymore - I have no idea why. This might be a bug in the new library version but probably has a different reason. While looking at this, I also added a loading indicator which is shown while the categories in the navigation panel are fetched.

@christianlupus any comments?

@seyfeb seyfeb added the Frontend Issue or PR related to the frontend code label Feb 5, 2021
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and we are up to date with the NC development again.

src/components/AppSettings.vue Show resolved Hide resolved
@christianlupus
Copy link
Collaborator

christianlupus commented Feb 6, 2021

For some reason editing the category name now doesn’t show the current name anymore - I have no idea why. This might be a bug in the new library version but probably has a different reason.

No it is a bug. I looked into it and I will open a PR/issue against the library after this comment. So we will have to wait for their fix.

Update:
See nextcloud-libraries/nextcloud-vue#1697

@seyfeb seyfeb merged commit 191c887 into master Feb 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the dependabot/npm_and_yarn/nextcloud/vue-3.5.4 branch February 6, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants