Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of prettier in order to have a clear coding standard #607

Merged
merged 5 commits into from
Feb 23, 2021
Merged

Usage of prettier in order to have a clear coding standard #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce31303
Updated workflow file to be correctly indented
christianlupus Feb 23, 2021
0f5ff6d
Apply prettier code styling without any modifications
christianlupus Feb 23, 2021
e40ce55
Manually rework tranlsations to be on one line
christianlupus Feb 23, 2021
4f32225
Add code style checker to workflow
christianlupus Feb 23, 2021
483033a
Update Changelog file
christianlupus Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 28 additions & 24 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,34 @@ on:
jobs:

php-lint:
name: Run PHP Linter and Code Style checker
runs-on: ubuntu-latest
steps:
- name: Checkout the project
uses: actions/checkout@v2
- name: Get PHP version
shell: bash
run: php -v
- name: Install Composer
shell: bash
run: >-
wget https://github.com/composer/getcomposer.org/raw/master/web/installer -O - -q |
php -- --quiet
- name: Install packages
shell: bash
run: composer install
- name: Run linter
shell: bash
run: composer lint:lint
- name: Run code style checker
shell: bash
env:
PHP_CS_FIXER_IGNORE_ENV: 1
run: composer cs:check
name: Run PHP Linter and Code Style checker
runs-on: ubuntu-latest
steps:
- name: Checkout the project
uses: actions/checkout@v2
- name: Get PHP version
shell: bash
run: php -v
- name: Install Composer
shell: bash
run: >-
wget https://github.com/composer/getcomposer.org/raw/master/web/installer -O - -q |
php -- --quiet
- name: Install packages
shell: bash
run: composer install
- name: Run linter
shell: bash
run: composer lint:lint
- name: Run code style checker
shell: bash
env:
PHP_CS_FIXER_IGNORE_ENV: 1
run: composer cs:check
- name: Check for formatting issues with vue files
shell: bash
run: npm run prettier


unit-tests:
name: Run the unittests
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
[#596](https://github.com/nextcloud/cookbook/pull/596) @seyfeb
- Updated dependency of eslint-config-prettier
[#603](https://github.com/nextcloud/cookbook/pull/603) @christianlupus
- Enforce basic code styling using prettier in vue files
[#607](https://github.com/nextcloud/cookbook/pull/607) @christianlupus

## Deprecated
- Obsolete routes to old user interface, see `appinfo/routes.php`
Expand Down
Loading