Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of PHPUnit as phar instead of composer dependency #780

Merged
merged 8 commits into from
Aug 10, 2021

Conversation

christianlupus
Copy link
Collaborator

This should allow us to use a more recent PHPUnit as we are no longer dependent on the nikic/php-parser of the 3rdparty NC core.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #780 (c781810) into master (9feede0) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #780      +/-   ##
===========================================
- Coverage      3.89%   3.84%   -0.05%     
+ Complexity      459     458       -1     
===========================================
  Files            20      20              
  Lines          1465    1484      +19     
===========================================
  Hits             57      57              
- Misses         1408    1427      +19     
Flag Coverage Δ
integration 2.89% <ø> (-0.04%) ⬇️
unittests 0.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Db/RecipeDb.php 0.00% <0.00%> (ø)
lib/Search/Provider.php 0.00% <0.00%> (ø)
lib/Service/RecipeService.php 0.00% <0.00%> (ø)
lib/Service/DbCacheService.php 0.00% <0.00%> (ø)
lib/Controller/MainController.php 0.00% <0.00%> (ø)
lib/Controller/RecipeController.php 0.00% <0.00%> (ø)

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>

Removed some overhead in file copy mode during testing

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
…ented)

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the maintenance/phpunit-as-phar branch from 51ecbf2 to c781810 Compare August 10, 2021 10:48
@christianlupus christianlupus merged commit d16b846 into master Aug 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the maintenance/phpunit-as-phar branch August 10, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant