Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some repair steps for the github actions #839

Merged
merged 6 commits into from
Oct 30, 2021
Merged

Some repair steps for the github actions #839

merged 6 commits into from
Oct 30, 2021

Conversation

christianlupus
Copy link
Collaborator

This should remove some of the warnings at the npm building during the GH action runs.

@christianlupus
Copy link
Collaborator Author

Closes #837

@christianlupus christianlupus linked an issue Oct 30, 2021 that may be closed by this pull request
Update npm before building #837
Closed
@codecov
Copy link

codecov bot commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #839 (d8e6b55) into master (953c776) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   21.27%   21.27%           
=======================================
  Files          20       20           
  Lines        1551     1551           
=======================================
  Hits          330      330           
  Misses       1221     1221
Flag Coverage Δ
integration 7.09% <ø> (ø)
unittests 14.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Oct 30, 2021 •
edited
Loading

Unit Test Results

  20 files    20 suites   7m 51s ⏱️
  66 tests   66 ✔️ 0 💤 0 ❌
660 runs  660 ✔️ 0 💤 0 ❌

Results for commit d8e6b55.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus marked this pull request as draft October 30, 2021 13:06
@christianlupus
Install latest version of NPM for actions
b8960e4 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Build the appinfo by default
c86ca6e 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Downgrade eslint to satisfy peer dependency
890edbe 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Corrected call to eslint to check vue as well
ab3f744 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Updated vue files to make eslint happy
8c50117 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Update Chaneglog
d8e6b55 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus linked an issue Oct 30, 2021 that may be closed by this pull request
downgrade eslint to meet peer dependency #838
Closed
@christianlupus christianlupus marked this pull request as ready for review October 30, 2021 16:17
@christianlupus christianlupus merged commit b848e7f into master Oct 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the maintenance/npm-repair branch October 30, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

downgrade eslint to meet peer dependency Update npm before building
1 participant
@christianlupus