Fix the UI glitch when keywords are empty (#857) #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyfeb
approved these changes
Feb 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
=======================================
Coverage 21.22% 21.22%
=======================================
Files 20 20
Lines 1555 1555
=======================================
Hits 330 330
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. |
christianlupus
force-pushed
the
fix-ui-glitch-empty-keywords
branch
from
2fdb6a3 to
1870a5a
Compare
Signed-off-by: Marcel Robitaille <marcelrobitaille11@gmail.com> Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
force-pushed
the
fix-ui-glitch-empty-keywords
branch
from
1870a5a to
17d4e86
Compare
|
closes #857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the UI glitch with a tiny blob in the keywords field when loading a recipe with empty keywords. The bug was caused by
keywords.split(',')whenkeywordsis an empty string. This will create an array of a single element: an empty string. Rendering this empty string as a keyword results in this little blob. The solution is to filter out empty strings after the call to.split().