Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/moment from 1.1.1 to 1.2.0 #925

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 21, 2022

Bumps @nextcloud/moment from 1.1.1 to 1.2.0.

Changelog

Sourced from @​nextcloud/moment's changelog.

1.2.0 – 2022-03-18

Changed

  • Dependency updates
Commits
  • 97bb906 1.2.0
  • f48e2dd v1.2.0 changelog
  • ae15d2f Dep update
  • 4f77cd5 Migrate lock file
  • d1d20cb Merge pull request #495 from nextcloud/test/french-seconds-ago
  • 7db0b2d Test alleged translation bug with 'seconds ago' and French
  • fdefa7f Merge pull request #415 from nextcloud/dependabot/npm_and_yarn/webpack-node-e...
  • 0aca8cd Merge pull request #477 from nextcloud/dependabot/npm_and_yarn/types/node-get...
  • 50721e2 Merge pull request #423 from nextcloud/dependabot/npm_and_yarn/handlebars-4.7.7
  • 2c09db4 Merge pull request #424 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.21
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@nextcloud/moment](https://github.com/nextcloud/nextcloud-moment) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/nextcloud/nextcloud-moment/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-moment/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-moment@v1.1.1...v1.2.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/moment"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #925 (623282b) into master (5d4232c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   20.20%   20.20%           
=======================================
  Files          20       20           
  Lines        1440     1440           
=======================================
  Hits          291      291           
  Misses       1149     1149           
Flag Coverage Δ
integration 5.90% <ø> (ø)
unittests 14.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Unit Test Results

  20 files    20 suites   7m 54s ⏱️
  66 tests   66 ✔️ 0 💤 0
660 runs  660 ✔️ 0 💤 0

Results for commit 623282b.

@christianlupus
Copy link
Collaborator

I am not sure where the moment library is used exactly. Maybe one of you two, @seyfeb and @MarcelRobitaille can have a look at this PR.

@MarcelRobitaille
Copy link
Collaborator

Looks like moment is only used in two places (RecipeCard.vue and RecipeView.vue). In both places, we just use moment(dt, moment.ISO_8601). I have checked that it gives the same output on this branch and on master.

Seems like a pretty small change too. Only dependencies. We should be ok.

@christianlupus christianlupus merged commit 30a0f04 into master Mar 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the dependabot/npm_and_yarn/nextcloud/moment-1.2.0 branch March 22, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants