Allow the client to specify the image type using Accept header #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 29.59% 32.30% +2.70%
==========================================
Files 31 32 +1
Lines 1561 1619 +58
==========================================
+ Hits 462 523 +61
+ Misses 1099 1096 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
seyfeb
approved these changes
May 11, 2022
Co-authored-by: Sebastian Fey <info@sebastianfey.de> Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
force-pushed
the
fix/954-image-file-types
branch
from
673e03c to
68a3171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #954
This is a quick fix for issue #954. This checks the accept header and returns a 406 HTTP error in case no JPG file was found on the server,
This is not yet capable to support other image files (like PNG) but this is the first step toward multi-type image files. The multi-type must be implemented separately as it is a more involved change/refactor involved.