Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to SCSS and cleanup css code #21

Closed
juliusknorr opened this issue Feb 1, 2017 · 5 comments
Closed

Move to SCSS and cleanup css code #21

juliusknorr opened this issue Feb 1, 2017 · 5 comments
Labels

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Feb 1, 2017

The css code has grown over the time and needs some cleanup.

Since SCSS is coming with Nc12 this might be helpful.

@bjornnorman
Copy link
Collaborator

I've been looking a little on the code while making some local changes and realized the build process just concatenates the js files and that source code lookups/inspections (using PHPStorm) fail without proper import statements etc. I have experience with Angular2 / Typescript, using webpack for building and SCSS processing - and karma/jasmine for unit-testing so I could probably update and rearrange the js code to support this if you like? The code would be easier to read and debug, and IDEs would likely be happier too ;)

@juliusknorr
Copy link
Member Author

@bjornnorman I already thought about migrating to angular2 but I don't have any experience with it until now. Is it possible to keep exiting dependencies such as ng-sortable/angular-ui-select/... ? How big would the initial change be? Can we keep the seperate anguar components and migrate them step by step?

Anyhow I would really appreciate your help there. 🚀

@bjornnorman
Copy link
Collaborator

bjornnorman commented May 15, 2017

Cool, I'll check the dependencies tomorrow. It'll require turning the modules etc into classes, adding corresponding import statements and using member vars in stead of $scope etc, but it's mostly search/replace. It's not really that much js code - so I can convince my employer to let me do that ;)
(And suddenly we had a National Constitution Day here in Norway - I'll be back at work tomorrow... :) )

@juliusknorr
Copy link
Member Author

@bjornnorman Awesome. I'm really looking forward to that. 👍 🎉

@pixelipo
Copy link
Contributor

Fixed in #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants