Move to SCSS #219
Move to SCSS #219
Conversation
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 33 33
Lines 973 973
=======================================
Hits 745 745
Misses 228 228 |
|
style.css is created but for some reason not loaded when I run the app... Plus it doesn't keep line break before P.S. I can take care of converting to 'proper' scss, if you don't mind. |
For Nextcloud >12 it will generate the file automatically and load it from something like
I guess that can be adjusted by using --output-style extended in the Makefile. But we should use compressed there anyway so we have a small file in the end.
That would be great. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
That is basically because the Nextclouds scss functionality only rewrites urls that are using quotes like url('../../iconfile') and not url(../../iconfile). We should add quotes everywhere for now. Maybe @pixelipo can do this when he does the migration to scss. I'll create a PR in nextcloud/server to fix this later as well. |
|
No problem. BTW, I have already grouped all styles, tomorrow I'll extract colors into variables and push here. That should be enough for first version of scss. |
|
@juliushaertl I added quotes in pr #220 |
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
|
@juliushaertl @artemanufrij please test this. I have converted to SCSS structure and added color variables. Also cleaned up few unused styles and simplified color palette (we literally had "50 shades of gray" 🤣 ) |
|
@pixelipo I will test it today afternoon. |
|
We can also close #160 once we merge this. There is still some unused CSS left, but it's not too bad and it can be cleaned up when needed. |
|
Pushed another commit to small issues with the board list. Otherwise looks great 👍 Awesome work @pixelipo. Thanks for that. |
css/style.scss
Outdated
| } | ||
|
|
||
| td { | ||
| padding: 0 10px; | ||
| padding: 3px 10px; |
There was a problem hiding this comment.
@juliushaertl please revert this line to padding: 0 10px;
If you think rows must be 50px high, then you can increase this to 25px: #boardlist .icon { padding: 25px; }
The difference between these 2 solutions is that with the latter, buttons fill full height of the row.
P.S. In my opinion, 44px is enough for row height anyway.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
I'll wait for #215 and try to restructure the css file then to make use of all the great features. 🎉
Fallback style.css will be generated when running make so it will keep working when using Nextcloud 11.