Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort boards non case sensitive #3410

Closed
mokkin opened this issue Nov 5, 2021 · 1 comment · Fixed by #3560
Closed

sort boards non case sensitive #3410

mokkin opened this issue Nov 5, 2021 · 1 comment · Fixed by #3560
Labels
1. to develop enhancement good first issue

Comments

@mokkin
Copy link
Contributor

mokkin commented Nov 5, 2021

Boards should be sorted non case sensitive as sometimes names are just correct or clearer written lowercase.

image
@Ben-Ro
Copy link
Contributor

Ben-Ro commented Jan 26, 2022 •
edited
Loading

Hey,
i encountered the same issue and think i found the problem. The sorting in the computed array boardsSorted wasn't with with the localeCompare method which is for case-insensitive sorting. With the fix a list of boards like the one in the Issue should look like this:
Bildschirmfoto 2022-01-26 um 20 23 11

Should i open an pull request for this or is there more to fix?

@Ben-Ro Ben-Ro mentioned this issue Jan 27, 2022
Merged
5 tasks
juliusknorr pushed a commit to Ben-Ro/deck that referenced this issue Mar 22, 2022
@juliusknorr
fixes nextcloud#3410
62d68ed 
Signed-off-by: ben <git@rott.io>
backportbot-nextcloud bot pushed a commit that referenced this issue Mar 22, 2022
@backportbot
fixes #3410
a88e028 
Signed-off-by: ben <git@rott.io>
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 20, 2022
@backportbot
fixes #3410
90938d5 
Signed-off-by: ben <git@rott.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort boards non case sensitive Ben-Ro/deck
4 participants
@mokkin @juliusknorr @stefan-niedermann @Ben-Ro