Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two close buttons #6428

Closed
alexanderdd opened this issue Oct 22, 2024 · 7 comments · Fixed by #6496
Closed

two close buttons #6428

alexanderdd opened this issue Oct 22, 2024 · 7 comments · Fixed by #6496
Assignees
Labels

Comments

@alexanderdd
Copy link

alexanderdd commented Oct 22, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

description
we have two close buttons, again #2897

To Reproduce
Steps to reproduce the behavior:

  1. open a card
  2. see two close buttons

Expected behavior
one close button

Screenshots
Image

This is on cloud.nc.com NC 30.0.1, I cannot look up Deck version

@luka-nextcloud
Copy link
Contributor

@alexanderdd I cannot reproduce the issue on stable30.

@UteHaus
Copy link

UteHaus commented Oct 24, 2024

I have the same issue with Docker Apache instance 30.0.1 and with a new FPM Instance 30.0.1 .

The one close Button is under the element id modal-description-hblme and the other one is under the element header (app_siede_bar_header)
Image

This image shows the modal container close button
Image

And this image the side bar close button
Image

And on the FMP Instance the two close buttons are overlap.
The close button from the modal container.
Image

And the close button from the site bar
Image

@alexanderdd
Copy link
Author

@luka-nextcloud you have access to cloud.nextcloud.com right? Can you reproduce it there? Cause it is still present for me (latest firefox).

@XueSheng-GIT
Copy link

I can reproduce this on NC 30.0.2rc1 and Deck 1.14.1.

@Gobytego
Copy link

Gobytego commented Nov 5, 2024

same here... but only on my main production server (snap version of 30.0.1and deck 1.14.1 ... the test/personal server i have does not do this same versions on that server...

@juliusknorr
Copy link
Member

Can reproduce

@luka-nextcloud
Copy link
Contributor

I can reproduce after enabling talk (spreed) app.

pschopen added a commit to pschopen/deck that referenced this issue Nov 11, 2024
Fixes nextcloud#6428 by simply hiding the second button underneath via an overlay.

Signed-off-by: Philip <65334274+pschopen@users.noreply.github.com>
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Nov 12, 2024
@luka-nextcloud luka-nextcloud moved this from 🏗️ In progress to 👀 In review in 📝 Office team Nov 13, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

6 participants