toggle navibar visibility #177
Conversation
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
|
fix for #123 |
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 33 33
Lines 955 955
=======================================
Hits 727 727
Misses 228 228 |
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
| @@ -902,6 +910,12 @@ button.button-inline:hover { | |||
| } | |||
| } | |||
|
|
|||
| @media (max-width: 768px) { | |||
| #app-navigation-toggle { | |||
| display: none !important; | |||
There was a problem hiding this comment.
@juliushaertl didn't you mention somewhere that navigation toggle should be available on mobile as well?
There was a problem hiding this comment.
I think we could dispense with navigation bar completely if we move all buttons/controls into board view.
There was a problem hiding this comment.
Yes let's add it to mobile as well, since otherwise it is not possible to access archived boards there.
There was a problem hiding this comment.
One more thing that needs to be fixed is that the button should also be visible on the boards list overview ;)
| @@ -24,6 +24,10 @@ app.controller('AppController', function ($scope, $location, $http, $route, $log | |||
| $rootScope.sidebar = { | |||
| show: false | |||
| }; | |||
| $rootScope.navibar = { | |||
| show: true | |||
There was a problem hiding this comment.
Any chance we could animate this?
There was a problem hiding this comment.
@pixelipo I have tried to animate it like files but I didn't found how it works in files.
It was my fist try :(
There was a problem hiding this comment.
They have a different approach - They are using CSS to move (translate) the main container (right one) over the navigation pane :)
There was a problem hiding this comment.
Maybe we can just use the same mechanism as in files. 😉
I guess that is ok for now, since it will stay hidden while using deck and just reappear on reload. |
Signed-off-by: Artem Anufrij artem.anufrij@live.de