Delete boards that users own once they are deleted #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
- Coverage 56.92% 56.81% -0.11%
==========================================
Files 77 77
Lines 3842 3849 +7
==========================================
Hits 2187 2187
- Misses 1655 1662 +7 |
|
Will this solution cover also boards that has been shared with the "deleted" user? |
nickvergessen
approved these changes
Jun 2, 2020
Yes, user acl entries already get removes some lines above https://github.com/nextcloud/deck/blob/master/lib/AppInfo/Application.php#L120 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/delete-boards-on-user-delete
branch
from
000607d to
1f4ab91
Compare
stefan-niedermann
approved these changes
Jun 3, 2020
|
Sorry for nut picking... but maybe you should also add a clean step on app upgrade which check for cases where boards are present but user has been deleted, just to make sure? It's still potential leaked data... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that users boards are properly removed on user delete