Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unneeded cardId parameter #2118

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Conversation

juliusknorr
Copy link
Member

No description provided.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@stefan-niedermann
Copy link
Member

This is a new minor version of the REST API, isn't it? Minor because it is fully backward compatible, but it should be documented in the REST API documentation in this case.

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 11, 2020

No, we don't change anything, just the parameter is not really needed so we don't need to pass it around. The URLs and behavior of the API stays the same.

@juliusknorr juliusknorr force-pushed the bugfix/noid/attachment-id-check branch from 2c9d2b9 to 062e4f7 Compare July 11, 2020 10:19
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/attachment-id-check branch from 062e4f7 to 6114c28 Compare July 11, 2020 10:21
@juliusknorr juliusknorr merged commit 06aad4b into master Jul 13, 2020
@juliusknorr juliusknorr deleted the bugfix/noid/attachment-id-check branch July 13, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants