Fix description in dark mode #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Jul 31, 2020
css/icons.scss
Outdated
| @@ -4,6 +4,9 @@ | |||
| .icon-deck { | |||
| background-image: url('../img/deck-dark.svg'); | |||
| } | |||
| body.dark .icon-deck { | |||
There was a problem hiding this comment.
to me this sounds like a hack.
With the navigation icon there is a filter: invert applied.
I see a similar problem now with the dashboard and unified search. I think we should think about a generic solution to this problem.
There was a problem hiding this comment.
I've removed the whole hardcoded .icon-deck now since it was a fallback for times before we had the icon-back-white mixin anyways.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/description-dark-theme
branch
from
1653b4b to
ec70237
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.