Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Naive approach on content sync #2159

Closed
wants to merge 1 commit into from
Closed

Conversation

juliusknorr
Copy link
Member

First attempt to tackle #256

  • Currently uses the lastModified date to detect changes with polling
  • Optionally sent current server time with responses (can be avoided when switching to etags)

UI wise we currently don't trigger an update of the user interface to avoid ui element that are changing places without user interaction, so instead a small banner is shown that the view is outdated which allows the user to trigger a refresh manually. cc @nextcloud/designers Does that make sense? I guess ideally we could just update all data that doesn't affect any item position changes. So a card reordering would still trigger the banner while simple label or text changes would be shown immediately in the UI.

image

Possibly better approaches

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added this to the 💥 1.2.0 milestone Oct 2, 2020
@juliusknorr juliusknorr modified the milestones: 1.2.0, 1.3.0 Nov 9, 2020
@juliusknorr juliusknorr removed this from the 1.3.0 milestone Dec 29, 2020
@dodedodo
Copy link

dodedodo commented Jan 5, 2021

UI wise we currently don't trigger an update of the user interface to avoid ui element that are changing places without user interaction

I feel like this should be optional. Situations arise where collaborative team meetings trigger a lot of overdue workflow updates. It's useful to actually see these changes being made in real-time (or within seconds).

@juliusknorr
Copy link
Member Author

UI wise we currently don't trigger an update of the user interface to avoid ui element that are changing places without user interaction, so instead a small banner is shown that the view is outdated which allows the user to trigger a refresh manually. cc @nextcloud/designers Does that make sense? I guess ideally we could just update all data that doesn't affect any item position changes. So a card reordering would still trigger the banner while simple label or text changes would be shown immediately in the UI.

@jancborchardt Any input on this?

@juliusknorr
Copy link
Member Author

🏓 @jancborchardt :)

@juliusknorr juliusknorr marked this pull request as draft April 16, 2021 15:30
@honzapatCZ
Copy link

honzapatCZ commented May 15, 2021

How is this going? This could be real usefull.
I think there could be like switch between announcement to refresh and auto refresh.

@juliusknorr
Copy link
Member Author

Closing for now, to be reopened when continuing, to get the list of open prs a bit more sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants