Fix design, dark mode and keyboard navigation of the board list #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliushaertl
commented
Aug 20, 2020
juliushaertl
commented
- Add 2px border in dark mode
- Increase card border radius
- Fix design of the all boards listing and allow keyboard navigation
- Remove legacy fallback for icons to make sure they are properly set in dark mode
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
Looks good, some possible dark mode changes: General: How does the keyboard navigation should work? |
jakobroehrl
approved these changes
Aug 21, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
The deck icon seems to be a caching issue, works fine here. The others are fixed (with a new release of nextcloud-vue-collections@0.8.1) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.