Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETag support for API endpoints #2245

Merged
merged 6 commits into from
Nov 10, 2020
Merged

ETag support for API endpoints #2245

merged 6 commits into from
Nov 10, 2020

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 29, 2020 •
edited
Loading

Implements a simplified version of #1650

  • ETag support for listing endpoints (board/stack)
  • ETag support for single object endpoints
  • Check individual modifying operations if they properly update the etag (last modified)
    • Comments do not update the last modified date yet

Follow up

  • ETag support for changing operations (ref Exclusive write access #925)
  • See if we need a separate field to store the etag so that it works somehow independent from the actual last modified date which is presented to the user
    • This would kind of make sense to not change the last modified date of a board, e.g. if a card was moved to the archive

cc @desperateCoder @stefan-niedermann

@juliushaertl juliushaertl added this to the ⭐ 1.1.0 milestone Aug 31, 2020
This was referenced Sep 1, 2020
Merged
Merged
@juliushaertl juliushaertl mentioned this pull request Sep 17, 2020
Merged
@juliushaertl
Copy link
Member Author

@stefan-niedermann sorry but I'll need to move this to the next minor since lots of other stuff blocked me from working on this

@juliushaertl juliushaertl modified the milestones: ⭐ 1.1.0, 1.1.1 Oct 2, 2020
@juliushaertl juliushaertl modified the milestones: 1.1.1, 1.1.2, 1.1.3 Oct 13, 2020
@juliushaertl juliushaertl modified the milestones: 1.1.3, 1.2.0 Nov 9, 2020
@juliushaertl
Expose ETag on single object get methods
8b7a30c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Update card modification date on label/user assignment changes
d916ef1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Add documentation for ETags
6a8e607 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl marked this pull request as ready for review November 10, 2020 16:18
@juliushaertl
Expose etag through JSON responses for child elements
a46d31c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Propagate ETag when comments are made
3fe849b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Propagate ETag when an attachment is being marked as deleted
e16c561 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 12ed9ae into master Nov 10, 2020
@juliushaertl juliushaertl deleted the enh/etag-api branch November 10, 2020 20:58
@stefan-niedermann
Copy link
Member

@desperateCoder let's rock 'n' roll 🤘 🎸 🎵

@juliushaertl juliushaertl mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing enhancement feature: api
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @stefan-niedermann