Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership #2496

Merged
merged 29 commits into from
Mar 22, 2022
Merged

Transfer ownership #2496

merged 29 commits into from
Mar 22, 2022

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 3, 2020

Rebased version of #1955

closes #1306

ToDo:

  • Ensure that unit tests pass
  • Make sure that psalm static code analysis passes
  • Add integration tests for transferring a board with example data to a different user
  • Follow up PR: UI
    • Create API endpoint to trigger the transfer logic
    • Add option to the UI to transfer a board to a different user

@stefan-niedermann
Copy link
Member

Will there also be some kind of REST API?

@juliusknorr
Copy link
Member Author

As of now this is only an occ command for admins. Whenever we expose it as a feature to users we will add an API for the user interface that can be used for the apps as well then.

@juliusknorr juliusknorr mentioned this pull request Nov 3, 2020
2 tasks
@juliusknorr juliusknorr force-pushed the transfer-ownership branch 2 times, most recently from ca564b1 to 5844d12 Compare November 3, 2020 14:19
@juliusknorr juliusknorr added this to the 1.2.0 milestone Nov 9, 2020
@juliusknorr juliusknorr requested a review from matchish November 10, 2020 11:55
@juliusknorr
Copy link
Member Author

@matchish I took the liberty to rebase and adjust some small issues i found during testing. Would be great if you could have another look if all that makes sense to you.

The major change is that when transfering ACL rules it should be enough to just drop the one for the new owner. The old owner will no longer have access unless there is a new rule added manually afterwards.

@juliusknorr juliusknorr marked this pull request as ready for review November 10, 2020 12:21
@juliusknorr juliusknorr modified the milestones: 1.2.0, 1.3.0 Nov 16, 2020
@juliusknorr juliusknorr removed this from the 1.3.0 milestone Dec 29, 2020
@estan
Copy link

estan commented May 10, 2021

It would be great if some dev could find time to review this. We have employees leaving and naturally want to transfer the ownership of some of their boards to other members of the team. We rather not mess about with running manual SQL statements against our database, even if it is probably safe if we get it right.

@max-nextcloud
Copy link
Contributor

I rebased this, will look into the failing tests and review the code changes next.

@max-nextcloud max-nextcloud force-pushed the transfer-ownership branch 6 times, most recently from 75e5aed to e07a456 Compare February 9, 2022 14:39
@juliusknorr juliusknorr mentioned this pull request Mar 4, 2022
39 tasks
juliusknorr and others added 21 commits March 22, 2022 08:23
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…hing to cleanup or persist there

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: conflicts
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

/backport to stable23

@juliusknorr
Copy link
Member Author

/backport to stable22

@juliusknorr juliusknorr merged commit 4027f40 into master Mar 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the transfer-ownership branch March 22, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

New Owner for a board
7 participants