Import from Trello #3182

vitormattos · 2021-07-10T14:37:53Z

Resolves: Export/import [$30] #87
Target version: master

Summary

Command to import json from Trello boards to Deck.

PS: The import command is ready to accept import from other systems and not just Trello. To create import from other systems it will be necessary to create a class for the system to be imported.

Command help:

deck:import --help
Description:
  Import data

Usage:
  deck:import [options]

Options:
      --system=SYSTEM   Source system for import. Available options: Trello API, Trello JSON.
      --config=CONFIG   Configuration json file. [default: "config.json"]
      --data[=DATA]     Data file to import. [default: "data.json"]

API documentation
See docs/API.md

TODO

Import flow
- Import board
- Import labels
- Import stacks
- Import cards
- Associate cards to labels
- Import comments
- Import attachments. Attachment URL added in the attachment table;
- Import user assigment
  - Relationship of Trello users to Nextcloud users
Import systems
- Import from Trello JSON (limited to 1000 Trello actions)
- Import from Trello API (no data limits to import)
- Implement architecture to make possible create an importer to other systems
Implement endpoints to import using Deck API
- Endpoint to import using API
- Endpoint to get available systems to import
- Endpoint to get json schema of a system to import

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Documentation (manuals or wiki) has been updated or is not required

vitormattos · 2021-07-17T17:21:55Z

Finally done!

Code coverage with tests is not ideal but I think it is acceptable.

The breaking tests are related to the setup of the server, it seems to me it has no relationship with this PR.

NOTE: It seems a good thing to remove support for PHP 7.2 and 7.3, I had to remove the beautiful arrow functions and heredoc.

vitormattos · 2021-07-19T22:15:09Z

Hi @juliushaertl,

I organized the code and I think it is now more beautiful and ready to accept other import sources.

I didn't implement the frontend in VueJS for importing but it already has the API endpoints ready to be consumed and working.

I thought about implementing Asana import but I've committed too much in this PR :-D

juliusknorr · 2021-07-23T05:44:39Z

First of all thanks a lot for your contribution, this is really awesome and looks very promising from a first quick look.

It might take a bit until I get to fully review it, but I'll dig into it in detail as soon as possible.

NOTE: It seems a good thing to remove support for PHP 7.2 and 7.3, I had to remove the beautiful arrow functions and heredoc.

We basically stick with what is compatible in the Nextcloud release, which is currently requiring 7.3 as a minimum PHP version. We can indeed drop 7.2 for any newer branch than stable1.2 which still needs it for Nextcloud 20.

vitormattos · 2021-07-23T17:20:55Z

@juliushaertl to make code review easier, I updated the documentation with the class diagram.

I used the extension yUML for the VSCode|Codium.

vitormattos · 2021-07-27T06:13:33Z

Hi @juliushaertl,

I returned to draft to implement import using Trello API.
It's ready for code review again, I updated the documentation too.

julien-nc

Great work!

Could you provide a test JSON file to import?

If I understand correctly, when importing from Trello API, all data is first loaded and stored in BoardImportTrelloApiService attributes. Once everything is loaded, Deck entities are added into the DB. I think there is a chance to reach the max RAM usage when importing big Trello projects.

I don't know how hard it would be to make those changes but: Would it be possible to import progressively while the data is loaded?
It would be very effective in saving RAM usage, even more thanks to the request pagination. Data could be added after each doRequest call.

lib/Controller/BoardImportApiController.php

lib/Service/BoardImportCommandService.php

lib/Service/BoardImportTrelloApiService.php

Check available helpers Default permission: view only Moved validate setting from helper to command Turn more easy create a importer Docblock and improvements on interface lcfirst on system property Helper moved to ImporHelper folder Moved fixtures to ImportHelper Rename settings to config Big refactor to move import methods to service Signed-off-by: Vitor Mattos <vitor@php.rio>

Big refactor to create route Import participants Signed-off-by: Vitor Mattos <vitor@php.rio>

Clean code Clean attachment table Signed-off-by: Vitor Mattos <vitor@php.rio>

Update documentation Start implementing getSystems route Code to route getSystems Controller to board import Change return Increase coverage Signed-off-by: Vitor Mattos <vitor@php.rio>

Fix visibility Make compatible with php 7.2 Remove returing instance Increase coverage Reduce psalm info Throw exception if system not defined Increment coverage Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

Fixes on getBoard tests Refactor Reduce psalm info Refactor to implement pattern Change order of methods to put all abstract first and all public first Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

Implement name of system to import Implement need validate data Fix allowed system list Start implementing Trello API service Signed-off-by: Vitor Mattos <vitor@php.rio>

Validate get boad change pattern of api params Import only one board by api Populate data from api Update class diagram Update documentation Add return when success Sort comments Fix order of cards Instructions of attachments Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

Co-authored-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: Vitor Mattos <vitor@php.rio>

Signed-off-by: Vitor Mattos <vitor@php.rio>

juliusknorr · 2021-12-30T10:20:27Z

Rebased and resovled the composer.lock conflict

juliusknorr · 2021-12-30T10:39:51Z

Great work, thanks a lot @vitormattos 👏

vitormattos marked this pull request as draft July 10, 2021 14:38

vitormattos force-pushed the import-from-trello branch 5 times, most recently from 91e0fbe to 65cd36c Compare July 11, 2021 04:49

vitormattos marked this pull request as ready for review July 11, 2021 04:50

vitormattos marked this pull request as draft July 12, 2021 15:16

vitormattos force-pushed the import-from-trello branch 4 times, most recently from 38fb15c to 9f612f4 Compare July 16, 2021 04:40

juliusknorr self-requested a review July 16, 2021 10:26

vitormattos force-pushed the import-from-trello branch from da76936 to 414ba24 Compare July 16, 2021 16:40

vitormattos marked this pull request as ready for review July 16, 2021 22:50

vitormattos marked this pull request as draft July 16, 2021 22:52

vitormattos marked this pull request as ready for review July 17, 2021 17:17

vitormattos force-pushed the import-from-trello branch from d9edb4b to 02e86d1 Compare July 19, 2021 15:50

vitormattos marked this pull request as draft July 24, 2021 22:03

vitormattos force-pushed the import-from-trello branch 2 times, most recently from 1a409a8 to a27fc62 Compare July 27, 2021 06:05

vitormattos marked this pull request as ready for review July 27, 2021 06:08

vitormattos force-pushed the import-from-trello branch from 1b0e754 to 8756203 Compare July 27, 2021 16:10

vitormattos mentioned this pull request Jul 30, 2021

Export/import [$30] #87

Closed

julien-nc requested changes Sep 15, 2021

View reviewed changes

lib/Controller/BoardImportApiController.php Show resolved Hide resolved

lib/Service/BoardImportCommandService.php Outdated Show resolved Hide resolved

lib/Service/BoardImportTrelloApiService.php Outdated Show resolved Hide resolved

vitormattos added 17 commits December 30, 2021 11:19

Import participants

c5d10da

Big refactor to create route Import participants Signed-off-by: Vitor Mattos <vitor@php.rio>

Clean attachment table

39a927d

Clean code Clean attachment table Signed-off-by: Vitor Mattos <vitor@php.rio>

Changes to make possible implement api endpoint

4138953

Update documentation Start implementing getSystems route Code to route getSystems Controller to board import Change return Increase coverage Signed-off-by: Vitor Mattos <vitor@php.rio>

Create route to get json schema to validate config

e01e4cf

Fix visibility Make compatible with php 7.2 Remove returing instance Increase coverage Reduce psalm info Throw exception if system not defined Increment coverage Signed-off-by: Vitor Mattos <vitor@php.rio>

Remove interact from command and implement bootstrap method

6714c89

Signed-off-by: Vitor Mattos <vitor@php.rio>

Default valute to board property fix command flow and refactor

19c6095

Fixes on getBoard tests Refactor Reduce psalm info Refactor to implement pattern Change order of methods to put all abstract first and all public first Signed-off-by: Vitor Mattos <vitor@php.rio>

Increase documentation

c7a37ea

Signed-off-by: Vitor Mattos <vitor@php.rio>

Start implementing Trello API service

202ea30

Implement name of system to import Implement need validate data Fix allowed system list Start implementing Trello API service Signed-off-by: Vitor Mattos <vitor@php.rio>

Add long comments with attachment

4561887

Signed-off-by: Vitor Mattos <vitor@php.rio>

Update documentation, import created

5b30577

Signed-off-by: Vitor Mattos <vitor@php.rio>

Remove unused codes

fda8a03

Signed-off-by: Vitor Mattos <vitor@php.rio>

Update lib/Service/BoardImportCommandService.php

a3959e3

Co-authored-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: Vitor Mattos <vitor@php.rio>

Make error more specific

24c8b2f

Signed-off-by: Vitor Mattos <vitor@php.rio>

Move all classes to a sub-namespace

f2b6934

Signed-off-by: Vitor Mattos <vitor@php.rio>

Replace glob by EventDispatcher

ccd5bce

Signed-off-by: Vitor Mattos <vitor@php.rio>

juliusknorr force-pushed the import-from-trello branch from f800cf1 to ccd5bce Compare December 30, 2021 10:19

juliusknorr removed the 2. developing label Dec 30, 2021

juliusknorr approved these changes Dec 30, 2021

View reviewed changes

juliusknorr added the 4. to release label Dec 30, 2021

juliusknorr merged commit b58913e into nextcloud:master Dec 30, 2021

juliusknorr added this to the 1.7.0 milestone Dec 30, 2021

vitormattos deleted the import-from-trello branch December 30, 2021 11:28

juliusknorr mentioned this pull request Jan 4, 2022

Import system for deck data #3507

Closed

juliusknorr mentioned this pull request Jan 13, 2022

Nextcloud 24 nextcloud/office#5

Closed

39 tasks

vitormattos mentioned this pull request Mar 2, 2022

Update deckimportfromtrello.csr nextcloud/app-certificate-requests#479

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import from Trello #3182

Import from Trello #3182

vitormattos commented Jul 10, 2021 •

edited

Loading

vitormattos commented Jul 17, 2021

vitormattos commented Jul 19, 2021

juliusknorr commented Jul 23, 2021 •

edited

Loading

vitormattos commented Jul 23, 2021

vitormattos commented Jul 27, 2021

julien-nc left a comment

juliusknorr commented Dec 30, 2021

juliusknorr commented Dec 30, 2021

Import from Trello #3182

Import from Trello #3182

Conversation

vitormattos commented Jul 10, 2021 • edited Loading

Summary

TODO

Checklist

vitormattos commented Jul 17, 2021

vitormattos commented Jul 19, 2021

juliusknorr commented Jul 23, 2021 • edited Loading

vitormattos commented Jul 23, 2021

vitormattos commented Jul 27, 2021

julien-nc left a comment

Choose a reason for hiding this comment

juliusknorr commented Dec 30, 2021

juliusknorr commented Dec 30, 2021

vitormattos commented Jul 10, 2021 •

edited

Loading

juliusknorr commented Jul 23, 2021 •

edited

Loading