Delete file shares through attachments API #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the file was deleted in the file structure of the user is not expected as the file might not only be related to the card. Signed-off-by: Julius Härtl <jus@bitgrid.net>
julien-nc
reviewed
Sep 6, 2021
There was a problem hiding this comment.
I don't know exactly all that what is changed by this PR.
Did some tests though:
- Before: Removing an attachment (local or directly uploaded) deletes the file
- With this PR, removing an attachment does not delete the file
- Another scenario with this PR:
- User A share a file F with user B (user share via Files)
- User A shares a board with user B
- User A adds file F as attachment to a card, file is shared with the card
- User B leaves the user share related with file F
- User B sees file F as attachment of the card but as a "pending share"
So it seems fine to me. Is there any other use case to check?
|
No the first case was what this PR was supposed to cover. Before still had the approach from the old attachments where the file would be deleted which doesn't fit the model with sharing a file from the files app anymore. |
|
/backport to stable22 |
|
/backport to stable1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the file was deleted in the file structure of the user is not
expected as the file might not only be related to the card.
Fixes #2877