Clone cards together with the board #3430

bahuma20 · 2021-11-18T00:17:36Z

Resolves: duplicating a board copies its lists, but not the cards #2797
Target version: master

Summary

Add the possibility to clone cards together with the board.

Also allow customizations when cloning.

In advanced options, cards can be moved to the first list and archived cards can be restored.

Follow Up

Copy archived/deleted cards
Copy all cards to specific comments
Copy attachments
Copy comments

TODO

Write tests (I need help here, i don't know how to do this in Nextcloud)
Maybe adjust documentation. Right now only REST api doc was updated.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Documentation (manuals or wiki) has been updated or is not required

stefan-niedermann · 2021-11-18T07:49:53Z

We should use one term (clone or copy)
Copy assignments, labels and due dates should be checked by default in my opinion
@juliushaertl do we really want the other two checkboxes? I consider them being edge cases, but at least they should be visually seperated from the others because they have another context and are some kind of "destructive" (they "change" or "modify" the data whole copying)

danir-de · 2021-12-15T16:04:41Z

@juliushaertl do we really want the other two checkboxes? I consider them being edge cases, but at least they should be visually seperated from the others because they have another context and are some kind of "destructive" (they "change" or "modify" the data whole copying)

Restoring archived cards would in no way be an edge case!
People use deck cloning to create a complex deck preset they can clone for repeating projects/tasks.

juliusknorr · 2022-04-11T13:54:08Z

Hello @bahuma20. I'm very sorry for the long delay on the feedback of this one, we'll have a look into it soonish to get this merged.

juliusknorr · 2022-04-11T13:56:40Z

docs/API.md

@@ -419,6 +419,25 @@ A 403 response might be returned if the users ability to create new boards has b

 ##### 200 Success

+### POST /boards/{boardId}/clone - Clone a board


In order to have this available through the API the required routes would also need to be handled for the BoardApiController similar to https://github.com/nextcloud/deck/pull/3430/files#diff-f126d1440653a8583122ad9fa4e49497074f2eabe1c511d76288a547ab8f1575

luka-nextcloud · 2022-04-21T06:51:57Z

lib/Service/BoardService.php

@@ -80,11 +85,13 @@ class BoardService {
 	public function __construct(
 		BoardMapper $boardMapper,
 		StackMapper $stackMapper,
+		CardMapper $cardMapper,


We have 2 injections of CardMapper, see below at line 97.

lib/Service/BoardService.php

luka-nextcloud · 2022-04-21T07:00:34Z

lib/Service/BoardService.php

@@ -662,6 +672,16 @@ public function clone($id, $userId) {
 		]);


We can separate the board cloning logics in a different class - The BoardMapper or the Service.

luka-nextcloud · 2022-04-21T07:13:17Z

lib/Service/BoardService.php

 		return $newBoard;
 	}

+	private function cloneCards(Board $board, Board $newBoard, $withAssignments = false, $withLabels = false, $withDueDate = false, $moveCardsToLeftStack = false, $restoreArchivedCards = false) {


We can put this Card cloning logic into the CardMapper class by creating a static method.

luka-nextcloud · 2022-04-21T07:42:29Z

src/components/navigation/AppNavigationBoard.vue

+						name="notification"
+						icon="icon-sound"
+						:disabled="updateDueSetting"
+						:class="{ 'forced-active': board.settings['notify-due'] === 'all' }"


I think we'd better put this expression as a computed value.

luka-nextcloud · 2022-04-21T07:43:34Z

tests/unit/Service/BoardServiceTest.php

@@ -103,11 +107,13 @@ public function setUp(): void {
 		$this->service = new BoardService(
 			$this->boardMapper,
 			$this->stackMapper,
+			$this->cardMapper,


Two CardMapper usages in the BoardService constructor.

jancborchardt · 2022-04-25T09:41:15Z

We should use one term (clone or copy)

Agree with @stefan-niedermann – we should use Copy everywhere since that is the more commonly used word.

danir-de · 2022-04-25T09:49:40Z

We should use one term (clone or copy)
Agree with @stefan-niedermann – we should use Copy everywhere since that is the more commonly used word.

Yes but Copy often requires pasting something and/or choosing where to copy it to.
Clone on the other hand is mostly used to create a copy (a clone) to the exact same location.

I'd say that Clone or Duplicate would be way more fitting than Copy.

small1 · 2022-12-13T07:55:28Z

This would be nice to have merged. This would solve a problem for a few projects where they have asked for this type of feature.

juliusknorr · 2023-08-22T12:23:03Z

I rebased this as there were quite some conflicting changes. Will have a look what is missing to get this in.

juliusknorr · 2023-10-18T12:47:47Z

lib/Service/BoardService.php

+		// TODO: Undelete cards
+		// TODO: Copy attachments (or not?)
+		// TODO: Copy comments (or not?)
+		// TODO: Move to specific column


Still valid?

Let's remove those from the code and track as enhancement follow up issues.

juliusknorr · 2023-10-18T12:48:18Z

lib/Service/BoardService.php

+		usort($stacks, function (Stack $a, Stack $b) {
+			return $a->getOrder() - $b->getOrder();
+		});


Sorting the same as above twice?

lib/Service/BoardService.php

src/components/navigation/AppNavigationBoard.vue

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

…ore to support clone options Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

make error message clear SPDX Header BoardCloneModal.vue Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>

luka-nextcloud · 2024-06-14T09:32:29Z

lib/Service/BoardService.php

+				$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_CARD, $card, ActivityManager::SUBJECT_CARD_CREATE);
+				$this->changeHelper->cardChanged($card->getId(), false);
+				$this->eventDispatcher->dispatchTyped(new CardCreatedEvent($card));


$card should be replaced by $newCard

luka-nextcloud

I think cypress tests should be added.

cyrillappert · 2024-09-12T12:35:57Z

We would also be very interested in this feature.

TheBestDestroyer · 2024-10-25T10:42:50Z

I would also be very interested in this feature. Why it has not been merged yet?

juliusknorr self-requested a review November 24, 2021 15:09

juliusknorr added this to the 1.7.0 milestone Dec 27, 2021

bahuma20 force-pushed the 2797-clone-cards branch from a0182bc to e53f9f4 Compare February 10, 2022 13:32

juliusknorr requested a review from luka-nextcloud April 11, 2022 13:52

juliusknorr added enhancement 3. to review labels Apr 11, 2022

juliusknorr requested a review from jancborchardt April 11, 2022 13:54

juliusknorr reviewed Apr 11, 2022

View reviewed changes

luka-nextcloud reviewed Apr 21, 2022

View reviewed changes

lib/Service/BoardService.php Show resolved Hide resolved

luka-nextcloud reviewed Apr 21, 2022

View reviewed changes

juliusknorr mentioned this pull request Apr 25, 2022

Clone cards while cloning boards #3691

Closed

4 tasks

juliusknorr modified the milestones: 1.7.0 (Nextcloud 24), 1.8.0 (Nextcloud 25) Apr 29, 2022

juliusknorr modified the milestones: 1.8.0 (Nextcloud 25), 1.10.0 (Nextcloud 27) Mar 21, 2023

juliusknorr force-pushed the 2797-clone-cards branch from 8b4176a to 1b87aed Compare August 22, 2023 12:22

juliusknorr force-pushed the 2797-clone-cards branch from 88dda3b to eac0400 Compare August 22, 2023 13:52

juliusknorr force-pushed the 2797-clone-cards branch from eac0400 to b627884 Compare October 18, 2023 10:58

juliusknorr reviewed Oct 18, 2023

View reviewed changes

lib/Service/BoardService.php Show resolved Hide resolved

juliusknorr reviewed Oct 18, 2023

View reviewed changes

src/components/navigation/AppNavigationBoard.vue Outdated Show resolved Hide resolved

juliusknorr added 2. developing and removed 3. to review labels Oct 18, 2023

juliusknorr self-assigned this Oct 25, 2023

putt1ck mentioned this pull request Dec 9, 2023

Copy Tags from One Board to Another in Deck #5368

Open

juliusknorr assigned grnd-alt and unassigned juliusknorr May 16, 2024

bahuma20 and others added 10 commits May 24, 2024 14:51

Add possibility to clone cards when cloning a board

4fd05b0

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Adjust BoardServiceTest to new dependencies

2bf80d8

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Add BoardCloneModal vue component to frontend. Adjust BoardApi and st…

19b4c5c

…ore to support clone options Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Add license and credits

f6cbf31

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Fix PHP code style

5e31d44

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Change default clone settings

8c88e5f

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Add accordion for advanced settings

3b0af35

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Fix bug which caused board to be cloned when clicking out of the modal

8d11c5a

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

Change wording of clone options

44c02e3

Signed-off-by: Max Bachhuber <max.bachhuber@bahuma.io>

fix: Rebase failures

81b08ef

Signed-off-by: Julius Härtl <jus@bitgrid.net>

grnd-alt force-pushed the 2797-clone-cards branch 2 times, most recently from c0d6d4f to 4ce2d79 Compare May 24, 2024 13:36

update cloneBoards phpdoc

0473133

make error message clear SPDX Header BoardCloneModal.vue Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>

grnd-alt force-pushed the 2797-clone-cards branch from 4ce2d79 to 0473133 Compare May 24, 2024 13:45

juliusknorr requested review from juliusknorr and luka-nextcloud June 12, 2024 08:22

luka-nextcloud reviewed Jun 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clone cards together with the board #3430

Clone cards together with the board #3430

bahuma20 commented Nov 18, 2021 •

edited by grnd-alt

Loading

stefan-niedermann commented Nov 18, 2021

danir-de commented Dec 15, 2021

juliusknorr commented Apr 11, 2022

juliusknorr Apr 11, 2022

luka-nextcloud Apr 21, 2022

luka-nextcloud Apr 21, 2022

luka-nextcloud Apr 21, 2022

luka-nextcloud Apr 21, 2022

luka-nextcloud Apr 21, 2022

jancborchardt commented Apr 25, 2022

danir-de commented Apr 25, 2022

small1 commented Dec 13, 2022

juliusknorr commented Aug 22, 2023

juliusknorr Oct 18, 2023

juliusknorr Jun 12, 2024

juliusknorr Oct 18, 2023

luka-nextcloud Jun 14, 2024

luka-nextcloud left a comment

cyrillappert commented Sep 12, 2024 •

edited

Loading

TheBestDestroyer commented Oct 25, 2024

		@@ -419,6 +419,25 @@ A 403 response might be returned if the users ability to create new boards has b

		##### 200 Success

		### POST /boards/{boardId}/clone - Clone a board

		@@ -662,6 +672,16 @@ public function clone($id, $userId) {
		]);

Clone cards together with the board #3430

Are you sure you want to change the base?

Clone cards together with the board #3430

Conversation

bahuma20 commented Nov 18, 2021 • edited by grnd-alt Loading

Summary

Follow Up

TODO

Checklist

stefan-niedermann commented Nov 18, 2021

danir-de commented Dec 15, 2021

juliusknorr commented Apr 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jancborchardt commented Apr 25, 2022

danir-de commented Apr 25, 2022

small1 commented Dec 13, 2022

juliusknorr commented Aug 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luka-nextcloud left a comment

Choose a reason for hiding this comment

cyrillappert commented Sep 12, 2024 • edited Loading

TheBestDestroyer commented Oct 25, 2024

bahuma20 commented Nov 18, 2021 •

edited by grnd-alt

Loading

cyrillappert commented Sep 12, 2024 •

edited

Loading