Switch from OC::$server->get to OCP\Server::get #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
cleanup/server-di
branch
2 times, most recently
from
8181538 to
a15269c
Compare
|
Ended up fixing a few more psalm issues 😆 |
CarlSchwan
force-pushed
the
cleanup/server-di
branch
from
a15269c to
7926c00
Compare
|
🤩 Very nice, also with the stub for circles |
CarlSchwan
force-pushed
the
cleanup/server-di
branch
3 times, most recently
from
5c96d78 to
03733ef
Compare
|
The remaining integration failure are looking to be related to server change Undefined mixin icon-black-white: apps/deck/css/deck.scss This needs to be ported away from scss compiled by the server |
|
Fixes for icon issues are in #3803 |
|
Pushed a fix for the tests to use the SymfonyAdapter in the template and opened nextcloud/server#32349 to get rid of that one. |
And add a bit more typing to some classes + psalm issues Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
cleanup/server-di
branch
from
ba48921 to
3a783a7
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
juliusknorr
force-pushed
the
cleanup/server-di
branch
2 times, most recently
from
e14adf2 to
0940ca4
Compare
CarlSchwan
commented
May 12, 2022
juliusknorr
force-pushed
the
cleanup/server-di
branch
2 times, most recently
from
750ad32 to
d80960c
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
cleanup/server-di
branch
from
d80960c to
ce7da62
Compare
2 tasks
juliusknorr
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch from OC::$server->get to OCP\Server::get
And add a bit more typing to some classes
TODO
Checklist