Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement card reference widget #4031

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Implement card reference widget #4031

merged 2 commits into from
Sep 12, 2022

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Sep 6, 2022

closes #4018

This adds a reference widget for deck cards.
It also fixes the DeckIcon.vue component so it uses the current color by default (which fixes an issue with dark themes).

Such URLs will be handled by @nextcloud/vue-richtext: https://nextcloud.local/index.php/apps/deck/#/board/2/card/11

It is necessary to use Talk master to try this. ⚠️ Warning: to compile Talk master, make sure you are using Node v14.x and NPM v7.x

Then send a card link in Talk, the displayed message should be like this

vokoscreenNG-2022-09-06_18-12-48.mp4

Bonus question, where does the music come from?

@julien-nc
Copy link
Member Author

I also fixed almost all eslint warnings and brought back eslint on compilation. Hope it's fine to do it in this branch. Necessary sooner or later IMO.

@julien-nc julien-nc force-pushed the enh/4018/reference-card branch from d5250c4 to 23cc703 Compare September 6, 2022 17:14
@julien-nc
Copy link
Member Author

Nevermind the static analysis failure. I did just like https://github.com/juliushaertl/integration_youtube/blob/5867a872bc9d54fc85d07fcee412f2c7fb5ac547/lib/Reference/YoutubeReferenceProvider.php#L48
so this will most likely be fixed on in server.

@karlitschek
Copy link
Member

this looks amazing. thank you

@AndyScherzinger
Copy link
Member

Looks great! 💙

Can we get both, deck-beta and talk-beta versions shipping this on tech-preview soon? This would be screenshoted by Marketing, so the sooner the better @eneiluj @nickvergessen

@julien-nc julien-nc force-pushed the enh/4018/reference-card branch from 33e7f98 to 9628928 Compare September 12, 2022 14:43
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! :) Design details:

  • If the card is left-aligned with the rest of the text it would look a bit nicer (we don’t center anything in there atm)
  • I’d also left-align the board and column name

@julien-nc
Copy link
Member Author

Julien Veyssier added 2 commits September 12, 2022 17:20
bring back eslint and stylelint on compilation, fix almost all warnings, ignore some

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the enh/4018/reference-card branch from 35a313c to c423f6e Compare September 12, 2022 15:21
@julien-nc julien-nc merged commit 2429061 into master Sep 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/4018/reference-card branch September 12, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reference widget for deck cards
5 participants