Implemented a colorpicker for all color selectors. #204, #395 #405
Conversation
…tcloud#395 Signed-off-by: oskar <oskar.kurz@gmail.com>
|
Thank you very much for the pull request. Looks great so far. Only a small nitpick - the color fields / picker in the left sidebar should all have the same width. |
| ng-click="selectColor(c)" | ||
| ng-class="{'selected': (c == newBoard.color), 'dark': (newBoard.color | textColorFilter) === '#ffffff' }"></div> | ||
| </div> | ||
| <div class="colorselect" ng-controller="ColorPickerController"> |
There was a problem hiding this comment.
There seems to be some issues with spacing here. Please fix
There was a problem hiding this comment.
I'm gonna look into this.
|
We'll need to move this icon over to server (it's the same one used in Calendar app and probably some other ones as well) and clean it up (it contains a lot of unnecessary code), but that is out of the scope of this PR. |
Signed-off-by: oskar <oskar.kurz@gmail.com>
|
I fixed the colorpicker width. |
|
@ossie Thanks for the fix and sorry for the long delay reviewing. Can you check the color selector in the left sidebar, when editing a board? The custom color picker seems to be hidden there now. |
|
Please let know how to refresh this in the Nextcloud? |
|
@plyaskin This feature is not merged yet. Once merged, it should be in the next release. |
|
@ossie Would it be ok for you if I take over to fix the last minor bugs? |
|
@juliushaertl I'm sorry for not reacting at all. The last months were stuffed with other (not programming related) projects. Thanks for fixing the last bugs. |
Added a colorpicker for both boards and labels.
Signed-off-by: Oskar Kurz oskar.kurz@gmail.com
Fix for #204 and #395