fix: Always return sorted index array to make sure a json array is the result #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e result Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
Will see if we can have a test case for this in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been lost in https://github.com/nextcloud/deck/pull/4452/files#diff-4975b048acd756b9fe8e6d63b016021d70ade5c1f79a5797ebe4dc6f2e87d34fL182 but the place was not that obvious. We need to use the array_values of the array_unique result to make sure that indexes are still properly in line and the later conversion to JSON results in an array not an object.