-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh/import from deck #4939
enh/import from deck #4939
Conversation
Passing run #1261 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
5c7116f
to
3bf1de9
Compare
26600db
to
4f60595
Compare
59614a6
to
5f3c262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thus far. Added some minor comments that came to my mind.
Since this is very php heavy might be good to get a review from a more php savvy person.
docs/export-import.md
Outdated
|
||
Importing can be done using the API or the `occ` `deck:import` command. | ||
|
||
Comments with more than 1000 characters are placed as attached files to the card. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are not exported, right? At least it says so in the export section - so maybe this should move into the section for the sources that come with comments?
occ deck:import my-file.json | ||
``` | ||
|
||
In case you are importing from a different instance you may use an additional config file to provide custom user id mapping in case users have different identifiers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add some more info about the config file here. At least from the docs right now i would not know what to do.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
fc7e08f
to
71801f3
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net> docs: Update import docs Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
e49a308
to
6672843
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
/backport to stable27 |
1 similar comment
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Possible follow ups
Notes
PHP 8.0 is fine since we need it for 26
Useful snipped for comparing the json export of a imported board