551_show_tag_title_on_cards_overview #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 80.19% 80.19%
=======================================
Files 46 46
Lines 1601 1601
=======================================
Hits 1284 1284
Misses 317 317 |
juliusknorr
reviewed
Jul 30, 2018
css/style.scss
Outdated
| width: 15px; | ||
| height: 20px; | ||
| padding: 0 4px; | ||
| margin: 0 2px 1px 0; |
There was a problem hiding this comment.
Lets probably use a 2px bottom margin as well, so they are nicly aligned when using multiple lines.
|
Look really good. Just one small comment. 😉 cc @nextcloud/deck |
Signed-off-by: Philippe Le Van <philippe.levan@kibatic.com>
Signed-off-by: Philippe Le Van <philippe.levan@kibatic.com>
juliusknorr
force-pushed
the
551_show_tag_title_on_cards_overview
branch
from
6a4126a to
508674f
Compare
juliusknorr
approved these changes
Jul 31, 2018
|
Thanks a lot, this is a big improvement 👍 |
|
Thanks for the review and the merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Le Van philippe.levan@kibatic.com
Summary
cards labels visible under the title
Checklist
N/A (only UI)
N/A (only UI)