Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity integration #607

Merged
merged 27 commits into from
Sep 7, 2018
Merged

Activity integration #607

merged 27 commits into from
Sep 7, 2018

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 4, 2018

Summary

Implement integration to the Nextcloud activity app.

TODO

  • Emit activity events for board changes
  • Load activity entries in the board sidebar
  • Load activity entries in the card sidebar
  • Fetch card activities on the board sidebar as well
  • Adjust tests for service classes
  • Test: \OCA\Deck\Activity

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #607 into master will increase coverage by 0.6%.
The diff coverage is 78.21%.

@@            Coverage Diff            @@
##           master     #607     +/-   ##
=========================================
+ Coverage   75.46%   76.07%   +0.6%     
=========================================
  Files          52       57      +5     
  Lines        1969     2474    +505     
=========================================
+ Hits         1486     1882    +396     
- Misses        483      592    +109

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Merging this as a first iteration, so we'll get translations and have it in the daily build already.

@juliusknorr juliusknorr merged commit f5691e6 into master Sep 7, 2018
@juliusknorr juliusknorr deleted the feature/211/activity branch September 7, 2018 14:18
@juliusknorr juliusknorr mentioned this pull request Oct 8, 2018
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant